Trunk Flagged Revisions

Fatal error: Undefined class constant 'FLAGGED' in lib/wiki/flaggedrevisionlib.php on line 21

Error after editing page

Error after categorizing

Fatal error: Using $this when not in object context in lib/wiki/renderlib.php on line 362

Tiki9 Flagged Revisions

Flagged revisions could use a little TLC. See http://doc.tiki.org/Flagged+Revisions#FAQ Here are some notes that are hoped to make that TLC easier for a newb.

1. How are they implemented in the database?
   See the Database references table below. When you approve a Flagged Revision, a record is appended in tiki_objects_attributes, with itemId=tiki_history.historyId, type="wiki history", attribute="tiki.history.moderation", and value="OK". Then follow table.fields tiki_objects_attributes. itemId => tiki_history.historyId => tiki_history.pageName and tiki_history.version, which are two fields which match those in tabe tiki_pages.
2. There is no way to list all current pending Flagged Revisions.
   1. A simple way to implement that might be to modify tiki-listpages.php by adding another Filter, very similar and following the tiki-listpages.php and tikilib.php code paths of "exact_match", selectable by a checkbox, labeled something like "Flagged Revisions pending approval". See tikilib.php function list_pages(). Need to define $mid = "where" clause, and "elseif ($type == 'flaggedrev_pending')".

Database references

When you save an edit to a wiki page, a new record is appended to tiki_history database table, with an incremented version number. The new current wiki content is stuffed in the data blob field (easily readable in a text editor). tiki-pagehistory.php?page=PageName will list each saved edit separately, but those that have been approved contain the text "(approved)" in the "Information" column; so where is that "(approved)" stored or calculated?

So, after all this review, I think we can implement a listing of wiki pages pending flagged-revision approval by adding, on tiki-listpages.php, to the Type: dropdown, which currently has only an option for "Pages not in structure", a new option called "Pages Pending Approval".

Reference Notes, Ignore

TPL files

1. tiki-flaggedrev_approval_header.tpl
   {if $prefs.flaggedrev_approval eq 'y' and $revision_approval}
   {if ($revision_approved or $revision_displayed) and $revision_approved neq $lastVersion}
   {if $lastVersion eq $revision_displayed}

PHP Files

1. lib/wiki/flaggedrevisionlib.php
   1. function page_requires_approval($pageName)
      1. $attributelib->set_attribute('wiki history', $version_info'historyId', $attribute, $value);
      2. $attribute="tiki.history.moderation", $value="OK" ($flag="moderation")
2. lib/wiki/histlib.php
3. tiki-pagehistory.php
   1. $auto_query_args = array('page', 'oldver', 'newver', 'compare', 'diff_style', 'show_translation_history', 'show_all_versions', 'history_offset', 'paginate', 'history_pagesize');
   2. $info = $tikilib->get_page_info($page);
   3. if (isset($_REQUEST'preview', $_REQUEST'flaggedrev', $_REQUEST'page') && $prefs'flaggedrev_approval' 'y' && $tiki_p_wiki_approve 'y') {$targetFlag = null;
      1. if 'approve'" class="wiki wikinew text-danger tips isset">$_REQUEST'approve' {
   
   $targetFlag = 'OK';
   $targetVersion = (int) $_REQUEST'approve';
   $targetFlag is what is pushed into the "value" field in database table tiki_object_attributes.
   1. $flaggedrevisionlib->flag_revision($info'pageName', $targetVersion, 'moderation', $targetFlag);
4. lib/attributes/attributelib.php

Notes

1. page_ref_id is a wiki Structure page reference. Interestingly, tiki-editpage.php?page=PageName&page_ref_id=5 has both a "page=" and a "page_ref_id=".
2. Is it possible to create a search like in tiki-search_replace.php, $results = $wikilib->get_pages_contains() that instead lists pages with pending approvals?
3. By selecting the appropriate checkboxes here , tiki-listpages.php can list "Last ver." and "Vers.", which are usually the same, but sometimes different, but, at the moment don't make sense to my test page pending Flagged Revisions, dangit. Also, at the bottom, it has a "Perform action with checked:" dropdown that could include an option to approve the pending Flagged Revisions, someday.

Tiki7 revamp

LPH is revamping this feature in Tiki7

• Needs to handle i18n
  • workflow
    • 0- Live
    • 1- Draft (one language is edited)
    • 2- Ready for content approval
    • 3- Content it approved, ready for translation
    • 4- Translation is done, both languages ready to go live
    • 0- Live

Notes for Tiki6

• "There is a staging page (not yet approved) for this page." -> A link should be added for people with perms
• * in page name conflicts with bad characters
• Approval button should be in history as well http://demo.tiki.org/staging/tiki-approve_staging_page.php?page=*NewPage1
• Make nicer UI when page is approved (no links to deleted page) and empty "Action" column
• http://demo.tiki.org/staging/tiki-pagehistory.php?page=ThisPageDoesNOtExistYet

Bugs/Tracker

Open

Pending

Closed

Related

• http://tech.slashdot.org/story/09/08/24/224259/Wikipedia-To-Require-Editing-Approval
• http://en.wikipedia.org/wiki/Wikipedia:Flagged_revisions
• http://features.sheep.art.pl/StagedCommits

• Staging
• Approval
• Flagged revision
• Flagged revisions
• Wiki Page Staging and Approval
• Wiki Staging and Approval